BREAKING: drop deprecated event.details alias on KeyborgFocusInEvent#175
Merged
layershifter merged 3 commits intoMay 22, 2026
Merged
Conversation
📊 Bundle size report
Unchanged fixtures
|
layershifter
changed the title
layershifter
marked this pull request as ready for review
May 18, 2026 10:33
mshoho
approved these changes
May 19, 2026
`event.details` was kept as an `@deprecated` alias of `event.detail` for Tabster and other early consumers. The known consumer chain (Tabster's src/State/FocusedElement.ts and elsewhere) reads `e.detail` exclusively, and the field has been marked deprecated for multiple releases. Dropping the field plus the per-dispatch assignment trims a few bytes from every focus-in event handler call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
layershifter
force-pushed
the
perf/drop-event-details-alias
branch
from
May 21, 2026 16:02
22407da to
3176fca
Compare
layershifter
enabled auto-merge (squash)
May 21, 2026 16:07
mshoho
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyborgFocusInEvent.detailsis an@deprecatedalias ofevent.detailcarried for early consumers that predate theCustomEvent.detailmigration. The known consumer chain — Tabster'ssrc/State/FocusedElement.tsand the rest of its codebase — readse.detailexclusively, and the field has been marked deprecated for several releases.Drops the interface field and the per-dispatch
event.details = detailsassignment insetupFocusEvent.The
KeyborgFocusInEventinterface collapses to a type alias:Matching
KeyborgFocusOutEvent's existing shape.Public API impact
KeyborgFocusInEventno longer carries the optionaldetailsfield. Consumers should useevent.detail. Worth a deprecation-removal call-out in the release notes (or a major bump if the maintainers prefer strict semver).